Merge branch 'main' into moo

mlr-org · Jan 23, 2022 · 1f59e13 · 1f59e13
2 parents 744710f + 6549303
commit 1f59e13
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 6 deletions.
diff --git a/R/AcqFunctionAEI.R b/R/AcqFunctionAEI.R
@@ -46,7 +46,6 @@ AcqFunctionAEI = R6Class("AcqFunctionAEI",
     #' @description
     #' Updates acquisition function and sets `y_effective_best`.
     update = function() {
-      super$update()
       xdt = self$archive$data[, self$archive$cols_x, with = FALSE]
       p = self$surrogate$predict(xdt)
       if (self$surrogate_max_to_min == 1) {  # minimization

diff --git a/R/AcqFunctionEI.R b/R/AcqFunctionEI.R
@@ -32,7 +32,6 @@ AcqFunctionEI = R6Class("AcqFunctionEI",
     #' @description
     #' Updates acquisition function and sets `y_best`.
     update = function() {
-      super$update()
       self$y_best = min(self$surrogate_max_to_min * self$archive$data[[self$surrogate$y_cols]])
     }
   ),

diff --git a/R/AcqFunctionEIPS.R b/R/AcqFunctionEIPS.R
@@ -42,7 +42,6 @@ AcqFunctionEIPS = R6Class("AcqFunctionEIPS",
     #' @description
     #' Updates acquisition function and sets `y_best`.
     update = function() {
-      super$update()
       self$y_best = min(self$surrogate_max_to_min[[self$y_col]] * self$archive$data[[self$y_col]])
     }
   ),

diff --git a/R/AcqFunctionPI.R b/R/AcqFunctionPI.R
@@ -33,7 +33,6 @@ AcqFunctionPI = R6Class("AcqFunctionPI",
     #' @description
     #' Updates acquisition function and sets `y_best`.
     update = function() {
-      super$update()
       self$y_best = min(self$surrogate_max_to_min * self$archive$data[[self$surrogate$y_cols]])
     }
   ),

diff --git a/R/AcqFunctionSmsEgo.R b/R/AcqFunctionSmsEgo.R
@@ -69,8 +69,6 @@ AcqFunctionSmsEgo = R6Class("AcqFunctionSmsEgo",
         stop("progress is not set.")  # needs self$progress here! Originally self$instance$terminator$param_set$values$n_evals - archive$n_evals
       }
 
-      super$update()
-
       n_obj = length(self$archive$cols_y)
       ys = self$archive$data[, self$archive$cols_y, with = FALSE]
       ys = as.matrix(ys) %*% diag(self$surrogate_max_to_min)