-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set_params #74
Comments
If you want to have a method, how about implementing the method in the param set, e.g. |
Good point, on the other hand this is really the only way a user ever interacts with the param set so maybe it is ok to make this exception / do both? I feel that In any case as a first step I would add the method and call it |
Ok actually I fully agree with you. |
I think we should really offer this
set_params
public method for Learners, Graphs etc. so we can use it in the book.Last time @mllg mentioned that we could just offer a s3 method that does something akin to
admittedly that is less work and we could simply add it in mlr3misc without touching other packages. But I think the downsight is that this is isomewhat inconsistent. The user then has to guess when something is implemented as a method vs a s function (?) I think offering both would be fine as well but I definitely think that the following should work.
This is also related to the suggestion that @mb706 made at some point, that it might make sense to introduce another class into the hierarchy that represents an object that has a param set and some other standardized properties? But even if this would make sense it would definitely take some time so I would suggest we make an mlr3misc release with this set_params utility that is already implemented and then add the method
set_params
toI am not sure whether I forgot something.
I can do this if you are ok @mllg @be-marc
The text was updated successfully, but these errors were encountered: