Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use toString, expect_named, lengths, expect_null, fixed in grepl #109

Merged
merged 4 commits into from
Jun 10, 2024
Merged

refactor: use toString, expect_named, lengths, expect_null, fixed in grepl #109

merged 4 commits into from
Jun 10, 2024

Conversation

m-muecke
Copy link
Member

@m-muecke m-muecke commented Jun 2, 2024 •
edited

  • Use testthat::expect_match()
  • Use testthat::expect_named()
  • Use testthat::expect_null()
  • Use toString(x)
  • Use lengths(x)
  • Use fixed for grep where possible
  • Updated .lintr config
  • Missing docs
  • Add missing explicit integers

@be-marc be-marc merged commit ebdcf1d into mlr-org:main Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-muecke @be-marc