Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add learners conversion for pipeop and graph #704

Closed
wants to merge 2 commits into from

Conversation

sebffischer
Copy link
Sponsor Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #704 (439d80d) into master (d41fcc9) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   95.21%   95.18%   -0.03%     
==========================================
  Files          87       87              
  Lines        3363     3365       +2     
==========================================
+ Hits         3202     3203       +1     
- Misses        161      162       +1     
Impacted Files Coverage Δ
R/GraphLearner.R 94.69% <50.00%> (-0.81%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mb706
Copy link
Collaborator

mb706 commented Oct 13, 2022

I wasn't aware of as_learners, but if this is the intended behaviour, wouldn't it make more sense to have as_learners.default just call as_learner in every case? (see mlr-org/mlr3#865)

@mb706
Copy link
Collaborator

mb706 commented Oct 13, 2022

(nice work otherwise, though, if @mllg says this shouldn't be in mlr3 we can merge)

@sebffischer sebffischer closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants