[Coding Conventions] Enforce sending self as first arg of instance me…

…thods (#5653)

mlrun/common/schemas/model_monitoring/model_endpoints.py

@@ -104,6 +104,7 @@ def from_flat_dict(cls, endpoint_dict: dict, json_parse_values: list = None):
         )
 
     @validator("monitor_configuration")
+    @classmethod
     def set_name(cls, monitor_configuration):
         return monitor_configuration or {
             EventFieldType.DRIFT_DETECTED_THRESHOLD: (
@@ -115,6 +116,7 @@ def set_name(cls, monitor_configuration):
         }
 
     @validator("model_uri")
+    @classmethod
     def validate_model_uri(cls, model_uri):
         """Validate that the model uri includes the required prefix"""
         prefix, uri = mlrun.datastore.parse_store_uri(model_uri)

mlrun/datastore/datastore_profile.py

@@ -37,6 +37,7 @@ class Config:
         extra = pydantic.Extra.forbid
 
     @pydantic.validator("name")
+    @classmethod
     def lower_case(cls, v):
         return v.lower()
 
@@ -304,6 +305,7 @@ def check_bucket(cls, v):
         return v
 
     @pydantic.validator("gcp_credentials", pre=True, always=True)
+    @classmethod
     def convert_dict_to_json(cls, v):
         if isinstance(v, dict):
             return json.dumps(v)

mlrun/model_monitoring/db/stores/sqldb/models/mysql.py

@@ -60,7 +60,7 @@ class _ApplicationResultOrMetric:
     )
 
     @declared_attr
-    def endpoint_id(cls):
+    def endpoint_id(self):
         return Column(
             String(40),
             ForeignKey(f"{EventFieldType.MODEL_ENDPOINTS}.{EventFieldType.UID}"),
@@ -81,7 +81,7 @@ class ApplicationMetricsTable(
 
 class MonitoringSchedulesTable(Base, MonitoringSchedulesBaseTable):
     @declared_attr
-    def endpoint_id(cls):
+    def endpoint_id(self):
         return Column(
             String(40),
             ForeignKey(f"{EventFieldType.MODEL_ENDPOINTS}.{EventFieldType.UID}"),

pyproject.toml

@@ -11,6 +11,7 @@ extend-select = [
     "I",   # isort
     "UP",  # pyupgrade
     "CPY", # flake8-copyright
+    "N805", # first argument of instance method should be 'self'
     "N806", # lowercase variable names
     "N816", # snake_case for global variable names
     "N999", # snake_case for module names

tests/model_monitoring/test_stores/test_sql.py

@@ -49,6 +49,7 @@ class TestSQLStore:
     def store_connection(tmp_path: Path) -> str:
         return f"sqlite:///{tmp_path / 'test.db'}"
 
+    @classmethod
     @pytest.fixture()
     def _mock_random_endpoint(
         cls,