Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coding Conventions] Enforce sending self as first arg of instance methods #5653

Merged
merged 1 commit into from
May 30, 2024
Merged

[Coding Conventions] Enforce sending self as first arg of instance methods #5653

merged 1 commit into from
May 30, 2024

Conversation

Yacouby
Copy link
Contributor

@Yacouby Yacouby commented May 29, 2024

https://iguazio.atlassian.net/browse/ML-6626

This PR addresses the 3rd python coding convention rule of the conventions that we defined:
"Use self as the first parameter in instance methods."

@Yacouby Yacouby force-pushed the self_convention branch 2 times, most recently from 9f5befe to 6d744e7 Compare May 29, 2024 12:45
jond01
jond01 reviewed May 29, 2024
View reviewed changes
Copy link
Member

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please address the comments in test_sql.py.

mlrun/model_monitoring/db/stores/sqldb/models/mysql.py Show resolved Hide resolved
tests/model_monitoring/test_stores/test_sql.py Outdated Show resolved Hide resolved
tests/model_monitoring/test_stores/test_sql.py Outdated Show resolved Hide resolved
tests/model_monitoring/test_stores/test_sql.py Outdated Show resolved Hide resolved
tests/model_monitoring/test_stores/test_sql.py Outdated Show resolved Hide resolved
mlrun/common/schemas/model_monitoring/model_endpoints.py Show resolved Hide resolved
@Yacouby Yacouby force-pushed the self_convention branch 3 times, most recently from 7736484 to 6974e82 Compare May 30, 2024 10:45
jond01
jond01 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@assaf758 assaf758 merged commit b799702 into mlrun:development May 30, 2024
11 checks passed
@Yacouby Yacouby deleted the self_convention branch June 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jond01 jond01 jond01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yacouby @jond01 @assaf758