BUG: tagging images leads to tag being appended to end of name

[ihs-nick]

When running function.deploy(), the value of tag is added at the end like "function-name-latest" instead of ":latest".

[Hedingber]

Hi @ihs-nick - thanks for reporting the issue!
The actual problem with here is not the tag, it's the fact that you have ./localhost:5000, as you can see : is not a valid for the repository name.
How did you set it ?
Note that in MLRun when the image starts with . that means it will be replaced with the configured default docker registry (in which : is valid obviously) so I guess you either should configure localhost:5000 as the default registry, and then image name should simply be .func-simple-demo-taxi-latest, or, set it manually, without the . prefix for auto completion - localhost:5000/func-simple-demo-taxi-latest

[ihs-nick]

Hi @Hedingber, thank you for responding. I realize that there are two issues here. I fixed the issue with the remote build by manually overriding the spec like you said like below:

taxi_func.spec.image = 'host.docker.internal:5000/func-simple-demo-taxi-latest' 
taxi_func.spec.build.image = 'host.docker.internal:5000/func-simple-demo-taxi-latest'

however, if I add a tag, it is added to the end like "func-simple-demo-taxi-" which doesn't seem correct. If I look at my local docker registry it says "func-simple-demo-taxi-latest:latest". I think it should be "func-simple-demo-taxi:latest". Especially since the function name cannot exceed a certain amount of characters.

[Hedingber]

Hi @ihs-nick,
You're right, I'll add a mission to fix this, and keep you updated on this

[nicklausbrown]

@Hedingber, I think I may have found the offending line while reviewing the source code. It is here:

mlrun/mlrun/runtimes/utils.py

Line 273 in ba52a71

return f".{repository}/func-{project}-{function.metadata.name}-{tag}"

[Hedingber]

Fixed by #860
Closing