[Builder] Fix function image tagging syntax

[ihs-nick]

Resolve issue #828

[ihs-nick]

@Hedingber, is there something else I need to do in order to get this approved? Right now this causes many copies of any function images that are built. This means that a container registry could be full of just one function.

Also, do you think that this should be changed as well?

mlrun/mlrun/runtimes/function.py

Line 553 in b7a5349

def get_fullname(name, project, tag):

The function is:

def get_fullname(name, project, tag):
    if project:
        name = f"{project}-{name}"
    if tag:
        name = f"{name}-{tag}"
    return name

I suspect it should be f"{name}:{tag}"

Here is another function that builds images:

mlrun/mlrun/utils/helpers.py

Line 519 in b7a5349

def enrich_image_url(image_url: str) -> str:

Maybe these should all be in one class for consistency?

[yaronha]

@ihs-nick AFAIK k8s names cant have :, but in the image it be the right solution

[Hedingber]

Hi @ihs-nick sorry it took me some time to get to this one, wanted to run this code through our more robust system tests to verify it doesn't break anything, thanks for the contribution!