[Functions] Mask sensitive data on store_function
#3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand, supported runtimes: remote,nuclio,serving,dask,job,spark,remote-spark,mpijob,local
Tankilevitch
force-pushed
the
mask-credentials-on-store-function
branch
from
71d34c0
to
c78e1c8
Compare
theSaarco
requested changes
Feb 19, 2023
mlrun/runtimes/base.py
Outdated
Comment on lines
299
to
313
| If access key is not mask (starts with secret prefix) then fill $generate so that the API will handle filling | ||
| of the credentials. | ||
| We rely on the HTTPDB to send the access key session through the request header and that the API will mask | ||
| the access key, that way we won't even store any plain access key in the function. | ||
| """ | ||
| if self.metadata.credentials.access_key and ( | ||
| # if contains secret reference or $generate then no need to overwrite the access key | ||
| self.metadata.credentials.access_key.startswith( | ||
| mlrun.model.Credentials.secret_reference_prefix | ||
| ) | ||
| or self.metadata.credentials.access_key.startswith( | ||
| mlrun.model.Credentials.generate_access_key | ||
| ) | ||
| ): | ||
| return |
There was a problem hiding this comment.
This is already merged - should probably rebase your changes.
mlrun/api/crud/functions.py
Outdated
| return mlrun.api.utils.singletons.db.get_db().store_function( | ||
| db_session, | ||
| function, | ||
| name, | ||
| function_obj.to_dict(), |
There was a problem hiding this comment.
In case there's no auth_info you do a new_function just to do to_dict() on it... A lot of effort for nothing. I guess instead you can do the new_function -> apply_enrichment -> to_dict inside the if checking for auth_info.
alonmr
approved these changes
Feb 19, 2023
…tials-on-store-function
alonmr
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 of - #3076
Related to https://jira.iguazeng.com/browse/ML-3156
Multiple adjustments had to be done:
auth_infois provided (will be done onstore_functionendpoint)-instead of_to align with the mlrun function naming conventions.tests_dbsand removed all tests of runtime base which are no longer relevant as we are no longer support running runtime base as well as storing unstructured functions.