Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Function] Fix ensure_function_has_auth_set to enrich function even if no access key was set but passed in auth info #3140

Merged
merged 8 commits into from Feb 22, 2023

Conversation

Tankilevitch
Copy link
Contributor

@Tankilevitch Tankilevitch commented Feb 21, 2023

Fixes - https://jira.iguazeng.com/browse/ML-3449
Follow up fix of - #3096

Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug in the new logic.

mlrun/api/api/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Tankilevitch Tankilevitch marked this pull request as ready for review February 22, 2023 12:41
@Tankilevitch Tankilevitch merged commit 748d377 into mlrun:development Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants