Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewTask -> new_task + added docstring #442

Merged
merged 5 commits into from Sep 22, 2020

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Sep 21, 2020

  • Created new_task with NewTask code, and now NewTask just show deprecation warning and call new_task
  • Added todo to remove NewTask in 0.7.0
  • Added docstring to new_task

Note:
Used FutureWarning and not DeprecationWarning mainly because DeprecationWarning is ignored by default while FutureWarning is not. also It's more "right" - FutureWarning is to notify end users while DeprecationWarning is for developers.
docs - https://docs.python.org/3/library/warnings.html

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Hedingber Hedingber merged commit dce2ee3 into mlrun:development Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant