Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #442 I created
new_task
to be insteadNewTask
.NewTask
remained but with a deprecation warning that it will be removed in0.7.0
, the chosen warning class wasFutureWarning
becauseDeprecationWarning
is ignored by default whileFutureWarning
is not.The problem is that our examples and demos use
NewTask
a lot.If we'll change all of them to
new_task
it will be problematic since users running MLRun <0.5.3 won't have thisnew_task
and they'll have to search for the examples relevant to their release which is very inconvient.On the other hand keeping them as is means that when running them the deprecation warning will be printed which is also not nice (new user running latest version with latest examples getting deprecation warnings)
So my plan is this:
PendingDeprecationWarning
which is ignored by default meaning users wouldn't really see it.0.7.0
when it will be very unlikely that someone is running<0.5.3
we'll change the examples & demos + change the warning toFutureWarning
- that way running latest code with latest examples won't print warnings, but using theNewTask
will print warnings0.9.0
when it will be very unlikely that someone is still usingNewTask
we'll remove it.Note:
This change (
NewTask
->new_task
) is very minor change, not funtional at all, only cosmetic, however I'm purposelyputting effort on doing its deprecation right, by that I'm "practicing" on it, and when real stuff will come, we'll already know what's the right way to do it