[Linting] Add Ruff formatter - replace black #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
152 files reformatted, 779 files left unchanged
`ruff check` failed. (E501 Line too long) Now `ruff check` & `ruff format` are stable.
But don't run the linter on it, as it produces many errors. See: https://docs.astral.sh/ruff/configuration/#jupyter-notebook-discovery
jond01
force-pushed
the
task/ruff-formatter
branch
from
3a18429
to
85c239c
Compare
liranbg
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff's formatter and Black are mostly compatible except for some corner cases that also appear here.
https://docs.astral.sh/ruff/faq/#how-does-ruffs-formatter-compare-to-black
It's much faster, though, and now
make linttakes less than 0.5 sec.Resolves ML-5300 together with #4740.
I recommend reviewing this commit by commit.
https://docs.astral.sh/ruff/formatter/
I have reviewed the changes in all the files.