[Nuclio] Delete Nuclio function when removing function of Nuclio runtime #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonmr
requested changes
Apr 25, 2024
TomerShor
requested changes
Apr 25, 2024
liranbg
requested changes
Apr 30, 2024
Comment on lines
195
to
208
| if len(functions) > 0: | ||
| if functions[0].get("kind") in RuntimeKinds.nuclio_runtimes(): | ||
| async with server.api.utils.clients.async_nuclio.Client( | ||
| auth_info | ||
| ) as client: | ||
| tasks = [] | ||
| for function in functions: | ||
| nuclio_name = mlrun.runtimes.nuclio.function.get_fullname( | ||
| name, project, function.get("metadata", {}).get("tag") | ||
| ) | ||
| tasks.append( | ||
| client.delete_function(name=nuclio_name, project_name=project) | ||
| ) | ||
| await asyncio.gather(*tasks) |
There was a problem hiding this comment.
few things here are not very clear
- the heuristic if checking the first function is nuclio and assuming rest are nuclio - perhaps worth a comment why do oyu assume it
- gather on tasks - if you have 500 functions, do you want to send 500 requests in parallel? why not group those requests by 10ens and send them all (remember not to fail on first but send all requests, log what fails and if one failed, then at the end - fail the operation
- will you wait for functions deletion? Id assume that is a long-process - thus, needs to be a background job.
- as stated on (2) - gather will fail if one deletion has failed. I suggest to wait for all before bailing
since (3) requires a change on response, I suggest moving this operation to functions_v2.py and have this function return background job
then you update
httpdb (sdk) to expect background job (and use v2)
open ticket for ui to use /v2/... endpoint and expect background job
TomerShor
requested changes
Apr 30, 2024
quaark
requested changes
Apr 30, 2024
quaark
requested changes
Apr 30, 2024
TomerShor
requested changes
Apr 30, 2024
liranbg
requested changes
Apr 30, 2024
liranbg
approved these changes
May 1, 2024
TomerShor
reviewed
May 1, 2024
TomerShor
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where deleting an MLRun function from the Nuclio runtime only removed the function from the database, leaving the associated Nuclio pod running.
Since an MLRun function can be mapped to multiple Nuclio functions with different tags, the deletion process first checks if the function is associated with Nuclio. Then, it retrieves all tags belonging to this function, generates Nuclio function names, and sends requests to the Nuclio API to delete each Nuclio function mapped to the given MLRun function.
Jira - https://iguazio.atlassian.net/browse/ML-3432
https://iguazio.atlassian.net/browse/ML-6293