[Application] Validate the version of Nuclio before deploying #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonmr
requested changes
May 23, 2024
alonmr
approved these changes
May 23, 2024
liranbg
requested changes
May 23, 2024
| @@ -172,7 +172,7 @@ def __init__( | |||
| class ApplicationRuntime(RemoteRuntime): | |||
| kind = "application" | |||
|
|
|||
| @min_nuclio_versions("1.12.7") | |||
| @min_nuclio_versions("1.13.1") | |||
There was a problem hiding this comment.
it worth changing min_nuclio_versions implementation that when using it on init it will log the Class name (ApplicationRuntime) and not init as it says nothing.
when using specific function (.deploy) it will log Class.deploy functionality not supported.
liranbg
approved these changes
May 23, 2024
mlrun/runtimes/nuclio/function.py
Outdated
| @@ -66,7 +66,7 @@ def wrapper(*args, **kwargs): | |||
| return function(*args, **kwargs) | |||
|
|
|||
| message = ( | |||
| f"{function.__name__} is supported since nuclio {' or '.join(versions)}, currently using " | |||
| f"'{function.__qualname__}' is supported since nuclio {' or '.join(versions)}, currently using " | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions with
kind="application"are deployed on non-supported nuclio versions. The function was generated, and then the error was raised:__init__ is supported since nuclio 1.13.1, currently using nuclio 1.12.14, please upgradeThe validation was done after the base deploy when calling API Gateways that were only supported by Nuclio 1.13.1.
We can fail the request early by doing validation in the
ApplicationRuntimeconstructor.https://iguazio.atlassian.net/browse/ML-6540
Also fixing the error message
https://iguazio.atlassian.net/browse/ML-6539