[Application] Fix the application runtime min nuclio versions error message #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
Jun 5, 2024
alonmr
reviewed
Jun 5, 2024
| @@ -73,7 +73,7 @@ def test_create_function_validate_min_nuclio_version( | |||
| self._generate_runtime(self.runtime_kind) | |||
| assert ( | |||
| str(exc.value) | |||
| == "'ApplicationRuntime.__init__' function requires Nuclio v1.13.1 or higher" | |||
| == "'Application Runtime' function requires Nuclio v1.13.1 or higher" | |||
There was a problem hiding this comment.
it says 'Application Runtime' function ... should be just 'Application Runtime'
There was a problem hiding this comment.
This is what @jillnogold suggested.
Please see the conversation here - https://iguazio.atlassian.net/browse/ML-6539
alonmr
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the error message will be
'Application Runtime' function requires Nuclio v1.13.1 or higherhttps://iguazio.atlassian.net/browse/ML-6539
related pr - #5618