-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Monitoring] Fix SQL store with multiple filter criteria #5629
Conversation
Remove the previous dummy test
Use a shared function and substitute the cases
The last analyzed should not be empty
It doesn't work otherwise (I did many tries): ``` NotImplementedError: This backend does not support multiple-table criteria within DELETE ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Few extra comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If it is not a big effort please add test for _delete_application_result
and pass to it application_name
- not mandatory for now.
Fixes ML-6541.
Add a test that fails before the fix introduced here:
test_unique_last_analyzed_per_app
.The bug comes from the fact that
sqlalchemy.sql.text
cannot combine by itself multiple conditions.