-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Monitoring] Implement TDEngine read metrics API #5642
Merged
assaf758
merged 23 commits into
mlrun:development
from
Eyal-Danieli:support-tdengine-endpoints-prod
May 30, 2024
Merged
[Model Monitoring] Implement TDEngine read metrics API #5642
assaf758
merged 23 commits into
mlrun:development
from
Eyal-Danieli:support-tdengine-endpoints-prod
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtopper
reviewed
May 29, 2024
…port-tdengine-endpoints-prod
…nto support-tdengine-endpoints-prod
jond01
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I had some minor comments.
My major question is about documentation: I think that installing TDEngine and setting the env vars has to be documented. If I want to test it myself, it would be hard to understand what I need to configure.
jond01
reviewed
May 29, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
reviewed
May 30, 2024
gtopper
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5620, this PR implements the metrics endpoints on top of the TDEngine.
In general, the implementation is quite similar to the V3IO Connector. For example,
read_metrics
endpoint includes:metrics
orresults
)DataFrame
resultDataFrame
into a list of metrics values per distinct results (usingdf_to_results_values
&df_to_metrics_values
that are now stored under the base class).In addition, to keep consistency with the V3IO TSDB schema, we updated the application result table and added a new tag -
result_kind
.Related JIRA: https://iguazio.atlassian.net/browse/ML-6557