Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model Monitoring] Employ the TSDB abstraction in the metrics endpoints #5620

Merged
merged 31 commits into from
May 26, 2024
Merged

[Model Monitoring] Employ the TSDB abstraction in the metrics endpoints #5620

merged 31 commits into from
May 26, 2024

Conversation

jond01
Copy link
Member

@jond01 jond01 commented May 23, 2024 •
edited
Loading

Implements ML-6429.

Add three abstract methods to the base TSDB connector class:

  • read_metrics_data - get application results/metrics values.
  • read_predictions - get the invocations metric values.
  • read_prediction_metric_for_endpoint_if_exists - get invocations metric existence.

Remove v3io_tsdb_reader.py. Move almost all the functions to tsdb/v3io/v3io_connector.py, except for get_invocations_fqn that went to the helpers module.

The main system test passed.

jond01 added 23 commits May 23, 2024 14:01
@jond01
Remove redundant v3io kv client
aa21a29
@jond01
Small refactoring
c88b855
@jond01
Remove TimeSeriesConnector from common consts
ed370f9 
Use the internal constant instead. It is used only
in v3io module.
@jond01
Small refactoring
9250cde
@jond01
Remove unused imports
114ec8e
@jond01
Move the v3io_tsdb_reader module into v3io_connector
678d939
@jond01
Use mm_constants and other small changes
ce08f81
@jond01
Move the "users" container into a constant
1e1b5df
@jond01
Move the functions to be static/class methods
2f76c2c
@jond01
Rename params constructor helper function
0a40e8b
@jond01
Use a V3IOTSDBConnector instance in the endpoints
397ee07
@jond01
Comment on the _wrap_coroutine_in_list function
43aeb79
@jond01
Abstract read_prediction_metric_for_endpoint_if_exists
d424f4f
@jond01
Make read_predictions a standard method
5a0439b
@jond01
Use the get_records method in read_predictions
ac8d823
@jond01
Abstract the read_predictions method
3169ec4
@jond01
Make read_metrics_data a standard method
7febad7
@jond01
Use the get_records method in read_metrics_data
6fdf478
@jond01
Abstract the read_metrics_data method
558166e
@jond01
Complete the endpoints abstraction
15f11f9
@jond01
Move get_invocations_fqn to helpers
b44786d 
Also, add a simple test
@jond01
Revert table -> table_name argument rename
d9336aa
@jond01
Specify the end time in the system test
ea54811
@assaf758 assaf758 merged commit 559850f into mlrun:development May 26, 2024
11 checks passed
@jond01 jond01 deleted the task/use-tsdb-abstraction-in-metrics-values-endpoint branch May 26, 2024 06:27
@Eyal-Danieli Eyal-Danieli mentioned this pull request May 27, 2024
Merged
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@jond01 @rokatyy
[Model Monitoring] Employ the TSDB abstraction in the metrics endpoin…
eae8228 
…ts (mlrun#5620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eyal-Danieli Eyal-Danieli Eyal-Danieli left review comments

@assaf758 assaf758 assaf758 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jond01 @assaf758 @Eyal-Danieli