Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Function] Optimise an error when function deletion is failed #5646

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

rokatyy
Copy link
Member

@rokatyy rokatyy commented May 28, 2024

Currently, the error string can be too long, so I have removed the additional string about failure for every Nuclio function. There will still be a message indicating that the deletion failed, including the MLRun function name.

So, instead of this

Failed to delete function func-nuclio. Errors: Failed to delete nuclio function run-nuclio-hello-world-func-nuclio: 412, message='Precondition Failed', url=URL('http://nuclio-dashboard.default-tenant.svc.cluster.local:8070/api/functions/'): : Function is "

we will have:

Failed to delete function func-nuclio. Errors: Function is used by api gateways"

Jira - https://iguazio.atlassian.net/browse/ML-6552

@rokatyy rokatyy marked this pull request as ready for review May 28, 2024 15:32
@rokatyy rokatyy requested review from liranbg and TomerShor May 28, 2024 15:32
server/api/api/utils.py Show resolved Hide resolved
@rokatyy rokatyy requested a review from TomerShor May 29, 2024 14:57
@TomerShor
Copy link
Member

@rokatyy can you updated the description with the new error after your latest change? I'd like to see how it look

@rokatyy
Copy link
Member Author

rokatyy commented May 30, 2024

@TomerShor updated

@TomerShor TomerShor merged commit 3ef9bb6 into mlrun:development Jun 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants