[Function] Optimise an error when function deletion is failed (#5646)

mlrun · Jun 2, 2024 · 3ef9bb6 · 3ef9bb6
1 parent 9925236
commit 3ef9bb6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/server/api/api/utils.py b/server/api/api/utils.py
@@ -1315,7 +1315,7 @@ async def _delete_function(
             auth_info, project, nuclio_function_names
         )
         if failed_requests:
-            error_message = f"Failed to delete function {function_name}. Errors: {' '.join(failed_requests)}"
+            error_message = f"Failed to delete function {function_name}. Errors: {';'.join(failed_requests)}"
             await _update_functions_with_deletion_info(
                 functions, project, {"status.deletion_error": error_message}
             )
@@ -1396,8 +1396,6 @@ async def delete_function(
             if isinstance(result, tuple):
                 nuclio_name, error_message = result
                 if error_message:
-                    failed_requests.append(
-                        f"Failed to delete nuclio function {nuclio_name}: {error_message}"
-                    )
+                    failed_requests.append(error_message)
 
     return failed_requests
diff --git a/server/api/utils/clients/async_nuclio.py b/server/api/utils/clients/async_nuclio.py
@@ -220,7 +220,9 @@ def _handle_error_response(
 
         self._logger.warning("Request to nuclio failed. Reason:", **log_kwargs)
 
-        mlrun.errors.raise_for_status(response, error_message)
+        raise mlrun.errors.STATUS_ERRORS[response.status](
+            error_message, response=response
+        )
 
     def _enrich_nuclio_api_gateway(
         self,