[Nuclio] List only functions with status when deleting Nuclio functions #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
approved these changes
Jun 10, 2024
Co-authored-by: TomerShor <90552140+TomerShor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - https://iguazio.atlassian.net/browse/ML-6744
The problem with duplicated error happened because
list_functions()returns 2 copies of the same functions. One of taglatestand another one of an empty tag. The one with empty tag is the same with latest, but without status, so them both point to the same Nuclio function. In order to avoid duplicated deletion of nuclio functions, we need to filter out those without status.