New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builder] Change registry URL configurations #582
Merged
Hedingber
merged 23 commits into
mlrun:development
from
Hedingber:align_builder_env_vars
Dec 10, 2020
Merged
[Builder] Change registry URL configurations #582
Hedingber
merged 23 commits into
mlrun:development
from
Hedingber:align_builder_env_vars
Dec 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
changed the title
[Builder] Use the main config instead env vars directly
[Builder] Change registry URL configurations
Dec 10, 2020
2 tasks
Hedingber
added a commit
to Hedingber/mlrun
that referenced
this pull request
Dec 11, 2020
Plus backport of jupyter image improvement from mlrun#582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.py
instead of reading from env var directly, this caused a change with the env vars naming:DEFAULT_DOCKER_REGISTRY
->MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY
,DEFAULT_DOCKER_SECRET
->MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY_SECRET