Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builder] Change registry URL configurations #582

Merged
merged 23 commits into from Dec 10, 2020

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Dec 9, 2020

  • Move builder configuration to use the main config.py instead of reading from env var directly, this caused a change with the env vars naming: DEFAULT_DOCKER_REGISTRY -> MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY, DEFAULT_DOCKER_SECRET -> MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY_SECRET
  • Added support to giving the docker repository inside the registry config value, which will override the default repository (mlrun)
  • Added logic in config so that when dbpath is being set we connect to the db (API) which will sync config from it
  • Bump kaniko tag - I had a bug similar Long builds fail with "UNAUTHORIZED: \"authentication required\"" GoogleContainerTools/kaniko#245 and upgrade solved it
  • related docs fixes
  • Reordered the jupyter dockerfile to improve caching

@Hedingber Hedingber changed the title [Builder] Use the main config instead env vars directly [Builder] Change registry URL configurations Dec 10, 2020
@Hedingber Hedingber marked this pull request as ready for review December 10, 2020 00:58
@Hedingber Hedingber merged commit 00b9a23 into mlrun:development Dec 10, 2020
Hedingber added a commit to Hedingber/mlrun that referenced this pull request Dec 11, 2020
Plus backport of jupyter image improvement from mlrun#582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant