Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System tests] Skip chart patching in provctl patch #593

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Dec 15, 2020

Our CI that builds image tag the images with <latest-version>-<commit-hash>
the <latest-version> is resolved by curl -sf https://pypi.org/pypi/mlrun/json | jq -r '.info.version' which (as of writing this) outputs 0.5.4.
It means that currently our system tests running on development are patching the system to versions like 0.5.4-daafbed the problem with this is that since this 0.5.x it makes provctl patch picking 0.4.x chart, while this PR that will be only in 0.6.x requires this chart PR that will only in 0.5.x charts.
Bottomline provctl patch gives the wrong chart which is causing these failures in the TestJobs suite:

E               mlrun.db.base.RunDBError: POST ***/api/build/function, error: runtime error: Default docker registry is not defined, set MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY/MLRUN_HTTPDB__BUILDER__DOCKER_REGISTRY_SECRET env vars

usr/local/lib/python3.7/site-packages/mlrun/db/httpdb.py:122: RunDBError

@Hedingber Hedingber merged commit 74321b2 into mlrun:development Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant