-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serving] Fix env config map generation and other veggies #5823
Conversation
server/api/api/utils.py
Outdated
@@ -32,6 +32,7 @@ | |||
from fastapi.concurrency import run_in_threadpool | |||
from sqlalchemy.orm import Session | |||
|
|||
import mlrun.common.constants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed if you removed the constant
server/api/utils/singletons/k8s.py
Outdated
if labels is None: | ||
labels = {label_name: name} | ||
else: | ||
labels[label_name] = name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if labels is None: | |
labels = {label_name: name} | |
else: | |
labels[label_name] = name | |
if labels is None: | |
labels = {} | |
labels[label_name] = name |
server/api/utils/singletons/k8s.py
Outdated
|
||
configmap_with_label = self.get_configmap(name, resource, namespace) | ||
configmap_with_label = self.get_configmap(name, namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this naming of name
variable is a bit confusing, so what I'd suggest is having resource_name
and configmap_name
to reduce this confusion.
TestNuclioRuntime::test_workaround_for_nuclio_bug
.conda-libmamba-solver
in ml-base for faster dependencies solving (like in mlrun image).with_repo
docstring clarification asked by @yonishelach and @ZeevRispler