Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serving] Fix env config map generation and other veggies #5823

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

alonmr
Copy link
Member

@alonmr alonmr commented Jun 20, 2024

  1. Config map resource name label value cannot be longer than 64 chars so use the function name without prepending the serving_conf prefix - fixes TestNuclioRuntime::test_workaround_for_nuclio_bug.
  2. Use conda-libmamba-solver in ml-base for faster dependencies solving (like in mlrun image).
  3. Set default project if not specified for artifact endpoints in httpdb.
  4. with_repo docstring clarification asked by @yonishelach and @ZeevRispler

@@ -32,6 +32,7 @@
from fastapi.concurrency import run_in_threadpool
from sqlalchemy.orm import Session

import mlrun.common.constants
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed if you removed the constant

Comment on lines 556 to 559
if labels is None:
labels = {label_name: name}
else:
labels[label_name] = name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if labels is None:
labels = {label_name: name}
else:
labels[label_name] = name
if labels is None:
labels = {}
labels[label_name] = name


configmap_with_label = self.get_configmap(name, resource, namespace)
configmap_with_label = self.get_configmap(name, namespace)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this naming of name variable is a bit confusing, so what I'd suggest is having resource_name and configmap_name to reduce this confusion.

@liranbg liranbg merged commit 407bddd into mlrun:development Jun 24, 2024
11 checks passed
@alonmr alonmr deleted the fix-serving-cm branch July 1, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants