Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to message formats #466

Merged
merged 1 commit into from
May 26, 2021
Merged

Minor fixes to message formats #466

merged 1 commit into from
May 26, 2021

Conversation

bifurcation
Copy link
Collaborator

This PR fixes a few small issues I noticed while reviewing mlspp for compliance with the spec:

  • The size of the Extension.extension_data vector needs to expand 2^32-1 to support trees for large groups
  • The content of the parent_hash extension is specified
  • authenticated_data is included in MLSPlaintextCommitContent so that it goes into the transcript
  • MLSPlaintextAuthData now carries an optional<MAC> even though the value is always present, so that the transcript matches the data on the wire

@kkohbrok kkohbrok mentioned this pull request Mar 22, 2021
Closed
@franziskuskiefer franziskuskiefer mentioned this pull request Mar 25, 2021
Closed
@seanturner
Copy link
Contributor

Discussed at 20210526 Interim. Merge

@raphaelrobert raphaelrobert merged commit ba6614e into main May 26, 2021
@eiqo eiqo mentioned this pull request Jun 28, 2021
Closed
@raphaelrobert raphaelrobert mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bren2010 Bren2010 Bren2010 approved these changes

@kkohbrok kkohbrok kkohbrok approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bifurcation @seanturner @Bren2010 @kkohbrok @raphaelrobert