Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loop option to pixbuf producer #21

Merged
merged 1 commit into from
Dec 27, 2012
Merged

Conversation

xaiki
Copy link
Contributor

@xaiki xaiki commented Dec 26, 2012

We use the pixbuf producer to show our tv channel's logo, but only want it to spin once per block,
hence this simple patch to add a 'loop' option to our .mlt.

Signed-off-by: Niv Sardi xaiki@evilgiggle.com

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
@xaiki
Copy link
Contributor Author

xaiki commented Dec 26, 2012

example use:

  <filter>
    <property name="mlt_service">watermark</property>
    <property name="resource">/srv/Mosca/LOGO_WALLKINTUNTV_%05d.png</property>
    <property name="composite.geometry"> 70%/20%:20%x20%</property>
    <property name="producer.loop">1</property>
  </filter>

@ddennedy
Copy link
Member

I am not certain what value this provides. The pixbuf looping can already be controlled simply by adjusting the length of the producer. If you want to loop once and then hold, then you can use 2 watermark filters with in/out set appropriately: one that loops and another that displays a single image.

@xaiki
Copy link
Contributor Author

xaiki commented Dec 27, 2012

the value is: simplicity,

I'd rather have this automatically sorted out by this trivial patch than having to re-write the .mlt if the artists adds a frame to the animation (or have to write code arround this to bloat my .mlt). (that way I can just tell art to drop the logo in a folder and everything updates auto-magically).

ddennedy added a commit that referenced this pull request Dec 27, 2012
Add loop option to pixbuf producer
@ddennedy ddennedy merged commit 334234d into mltframework:master Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants