musl libc support #298
Merged
musl libc support #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl has no macro, so it can not be detected straigthforward. HAVE_STRTOD_L tells that strdod_l() is available HAVE_LOCALE_H tells that the header locale.h is available
|
LGTM. But Dan is the expert on this subject. We should wait for him to review after he gets back. |
ddennedy
approved these changes
Feb 1, 2018
| @@ -30,7 +30,7 @@ | |||
| #include <sys/param.h> | |||
| #endif | |||
|
|
|||
| #if defined(__GLIBC__) && !defined(__APPLE__) | |||
| #if defined(__GLIBC__) && !defined(__APPLE__) || HAVE_LOCALE_H | |||
There was a problem hiding this comment.
This should have parenthesis to clarify the order of logical operations. && is higher precedence than ||:
#if (defined(__GLIBC__) && !defined(__APPLE__)) || HAVE_LOCALE_H
alfredfo
added a commit
to alfredfo/mlt
that referenced
this pull request
Jun 22, 2022
reverts: mltframework#298. There is no gurantee that either HAVE_STRTOD_L or HAVE_LOCALE_H will be defined at compile-time. Try for example building this project :) The locale usage is now defined in POSIX and therefore we can now assume it will be available on Linux, except for ancient systems. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/locale.h.html Another way of dealing with this would be to have a global mlt_config.h where HAVE_LOCALE_H and HAVE_STRTOD_L are defined to values determined when mlt is installed.
Merged
ddennedy
pushed a commit
that referenced
this pull request
Jun 25, 2022
reverts: #298. There is no gurantee that either HAVE_STRTOD_L or HAVE_LOCALE_H will be defined at compile-time. Try for example building this project :) The locale usage is now defined in POSIX and therefore we can now assume it will be available on Linux, except for ancient systems. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/locale.h.html Another way of dealing with this would be to have a global mlt_config.h where HAVE_LOCALE_H and HAVE_STRTOD_L are defined to values determined when mlt is installed.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musl has no macro, so it can not be detected straigthforward.
HAVE_STRTOD_L tells that strdod_l() is available
HAVE_LOCALE_H tells that the header locale.h is available