fix audio artifacts with DNxHR Convert/Reverse

https://forum.shotcut.org/t/problem-with-sound-in-shotcut/35470
mltframework · Sep 16, 2022 · 4bb6241 · 4bb6241
1 parent 37a03cd
commit 4bb6241
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/dialogs/transcodedialog.cpp b/src/dialogs/transcodedialog.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2021 Meltytech, LLC
+ * Copyright (c) 2017-2022 Meltytech, LLC
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -128,8 +128,8 @@ void TranscodeDialog::on_horizontalSlider_valueChanged(int position)
         ui->formatLabel->setText(tr("Lossy: I-frame–only %1").arg("H.264/AC-3 MP4"));
         break;
     case 1:
-        ui->formatLabel->setText(tr("Intermediate: %1").arg(m_isProgressive ? "DNxHR/ALAC MOV" :
-                                                            "ProRes/ALAC MOV"));
+        ui->formatLabel->setText(tr("Intermediate: %1").arg(m_isProgressive ? "DNxHR/PCM MOV" :
+                                                            "ProRes/PCM MOV"));
         break;
     case 2:
         ui->formatLabel->setText(tr("Lossless: %1").arg("Ut Video/PCM MKV"));

diff --git a/src/widgets/avformatproducerwidget.cpp b/src/widgets/avformatproducerwidget.cpp
@@ -913,7 +913,7 @@ void AvformatProducerWidget::convert(TranscodeDialog &dialog)
             args << "-preset" << "medium" << "-g" << "1" << "-crf" << "15";
             break;
         case 1:
-            args << "-f" << "mov" << "-codec:a" << "alac";
+            args << "-f" << "mov" << "-codec:a" << "pcm_f32le";
             if (dialog.deinterlace() || ui->scanComboBox->currentIndex()) { // progressive
                 args << "-codec:v" << "dnxhd" << "-profile:v" << "dnxhr_hq" << "-pix_fmt" << "yuv422p";
             } else { // interlaced
@@ -1116,7 +1116,7 @@ void AvformatProducerWidget::on_reverseButton_clicked()
         if (m_producer->get_int("video_index") == -1)
             meltArgs << "vn=1" << "video_off=1";
 
-        ffmpegArgs << "-f" << "mov" << "-codec:a" << "alac";
+        ffmpegArgs << "-f" << "mov" << "-codec:a" << "pcm_f32le";
 
         switch (dialog.format()) {
         case 0: