Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting onto the Source file exports a full-white video #840

Closed
Ekleog opened this issue Mar 21, 2020 · 4 comments
Closed

Exporting onto the Source file exports a full-white video #840

Ekleog opened this issue Mar 21, 2020 · 4 comments

Comments

@Ekleog
Copy link

Ekleog commented Mar 21, 2020

Steps to reproduce:

  • shotcut foo.mp4
  • Add a crop filter
  • Export to foo.mp4
  • Observe that the exported file is pure white

Suggested solution: Either have export work properly (presumably hard), or refuse to export to the source file (presumably easier).

(I guess this'll be closed like #839, but wanted to have the fact I believe this is a bug written down somewhere in the bug tracker in case other people ever read it, so they can have an idea of how to make shotcut more new-user-friendly)

@ddennedy
Copy link
Member

Actually, we already have code to prevent this, but it is not working in this case or set of steps. I will try to reproduce it.

@ddennedy
Copy link
Member

ddennedy commented Mar 22, 2020

I do not reproduce this with version 20.02 on Linux. Step 1 fails because you must qualify the file name with "$PWD/foo.mp4" or use some other full path. Next, in step 3 when I enter test.mp4 (I am using test.mp4 as source), I get this

Screenshot from 2020-03-21 18-11-13

If I choose Yes, I get the warning dialog from the code I mentioned:

Screenshot from 2020-03-21 18-12-31

Even when I leave off ".mp4" in the file save dialog, to let the automatic extension be added, I do not reproduce the problem. Even if I add the clip from Source to Timeline and export from Timeline, I do not reproduce it. This report lacks version and OS information and perhaps some other steps.

@ddennedy
Copy link
Member

I did reproduce this on the flatpak. I also found the first step works with a relative path with the flatpak. I was testing in previous with the portable and snap. I made a fix for that loading issue. Now, as for the export problem with flatpak, I am very surprised to see that code fail.
I still get a warning:

Screenshot from 2020-03-21 18-41-03

Oh, I see now from looking at the export job's XML. The reason it failed is because the target file name, which is absolute, is not found in the XML, which has only a relative path. Typically, this is prevented because the app launch directory is different than the current directory causing a full path in the XML. I also reproduced this by running my development executable.

@ddennedy ddennedy added this to the v20.04 milestone Mar 22, 2020
@Ekleog
Copy link
Author

Ekleog commented Mar 22, 2020

Great, thank you! And sorry for having forgotten to include version numbers, and made you make more work for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants