Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fade out not working after trim in #1340

Merged
merged 1 commit into from Oct 2, 2022
Merged

Fix fade out not working after trim in #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/mltcontroller.cpp
View file
Open in desktop
Expand Up @@ -1253,6 +1253,28 @@ void Controller::adjustFilter(Mlt::Filter *filter, int in, int out, int inDelta,
}
filter->set_in_and_out(in + inDelta, filter->get_out());
emit MAIN.serviceInChanged(inDelta, filter);
} else if (filterName.startsWith("fadeOut")) {
if (!filter->get(kShotcutAnimOutProperty)) {
// Convert legacy fadeOut filters.
filter->set(kShotcutAnimOutProperty, filter->get_length());
}
filter->set_in_and_out(in + inDelta, filter->get_out());
if (filterName == "fadeOutBrightness") {
const char *key = filter->get_int("alpha") != 1 ? "alpha" : "level";
filter->clear(key);
filter->anim_set(key, 1, filter->get_length() - filter->get_int(kShotcutAnimOutProperty));
filter->anim_set(key, 0, filter->get_length() - 1);
} else if (filterName == "fadeOutMovit") {
filter->clear("opacity");
filter->anim_set("opacity", 1, filter->get_length() - filter->get_int(kShotcutAnimOutProperty), 0,
mlt_keyframe_smooth);
filter->anim_set("opacity", 0, filter->get_length() - 1);
} else if (filterName == "fadeOutVolume") {
filter->clear("level");
filter->anim_set("level", 0, filter->get_length() - filter->get_int(kShotcutAnimOutProperty));
filter->anim_set("level", -60, filter->get_length() - 1);
}
emit MAIN.serviceInChanged(inDelta, filter);
} else if (!filter->get_int("_loader") && filter->get_in() <= in) {
filter->set_in_and_out(in + inDelta, filter->get_out());
emit MAIN.serviceInChanged(inDelta, filter);
Expand Down