Featurization API tweaks #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `custom_functions` parameter to featurization functions which takes a dict of functions to evaluate, or a dask graph of computations to perform.
Tweak formatting standard for multichannel data: now multiple channels w/ different lengths can be passed in as a list of lists of 1d arrays.
|
👍 from me |
|
+1 from me |
| ERROR_VALUE = 1e-4 | ||
| # Specify default values for missing times/errors | ||
| DEFAULT_MAX_TIME = 1.0 | ||
| DEFAULT_ERROR_VALUE = 1e-4 |
There was a problem hiding this comment.
Should this default to NaN?
There was a problem hiding this comment.
I would like for it to, but currently a lot of the old TCP features will break if errors aren't passed in, or if they're taken to be zero. Even worse, we'd actually get different feature values if we changed this to 1e-1 or 1e-10; I'm just choosing 1e-4 to stay consistent with the old code.
|
Good job on the testing code, Brett. I'll add an issue on Travis coverage to ensure that we keep this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{'some_feature': f}wheref(t,m,e)is a featurization function, or as a dask graph{'some_feature': (f, 't', 'm', 'e')}.featurize_time_series