Simple fix to allow extension settings to be seen. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The evaluation of the extension settings must be done in the listener handler to allow the project evaluation to take effect. Without this change the enabled property or the validation of the selected colorscheme value will simply have no effect.
|
Already implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluation of the extension settings must be
done in the listener handler to allow the project
evaluation to take effect. Without this change the
enabled property or the validation of the selected
colorscheme value will simply have no effect.
The changes here simply move the enabled option
evaluation and the validation of colorscheme code.
Tested manually since there was not much in the way
of unit tests for this plugin already.
If you prefer to have unit tests added for this let me know.