Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Diffplex avoid exporting the Log class? #115

Closed
willdean opened this issue Dec 4, 2023 · 1 comment · Fixed by #116
Closed

Could Diffplex avoid exporting the Log class? #115

willdean opened this issue Dec 4, 2023 · 1 comment · Fixed by #116

Comments

@willdean
Copy link
Contributor

willdean commented Dec 4, 2023

Diffplex contains a static class called Log, which has public visibility. As far as I can tell, it's only used in Differ.cs, and only when the project is built with LOG defined.

Diffplex publishing this class has the slightly undesirable side effect of competing in the eyes of tools like Resharper / Rider with the static Log class used by logging tools like Serilog. The first time we type Log. in any new file in any solution which uses Diffplex we have to disambiguate between the real Log class and the one from Diffplex.

In an ideal world I might be able to tell Resharper/Rider to ignore the Diffplex Log class, but I have not found a way to do this - would it be possible for Diffplex to stop exporting this class which seems only there for internal use anyway?

I'm happy to submit a PR if that would be helpful, though it's simply a matter of removing the word "public" on line 5 of Log.cs so a PR might be more faff than is necessary.

Many thanks.

Edit: Turns out there is a solution to this, at least in Rider - see SO answer

@mmanela
Copy link
Owner

mmanela commented Dec 7, 2023

Thanks for the comment, I am fine to accept that change.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants