Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite failure, presumably bumped dependency #28

Closed
snoyberg opened this issue Apr 2, 2022 · 1 comment · Fixed by #29
Closed

Test suite failure, presumably bumped dependency #28

snoyberg opened this issue Apr 2, 2022 · 1 comment · Fixed by #29

Comments

@snoyberg
Copy link

snoyberg commented Apr 2, 2022

I'm not sure which dependency changed, but in Stackage I noticed this failure:

    Failures:

      tests/Text/MMark/Extension/TestUtils.hs:30:10:
      1) Text.MMark.Extension.ObfuscateEmail.obfuscateEmail, when URI has the mailto scheme, produces the correct HTML
           expected: "<p><a class=\"foo\" data-email=\"me@example.org\" href=\"javascript:void(0)\">Enable JavaScript to see this email</a></p>\n"
            but got: "<p><a class=\"foo\" data-email=\"me%40example.org\" href=\"javascript:void%280%29\">Enable JavaScript to see this email</a></p>\n"

      To rerun use: --match "/Text.MMark.Extension.ObfuscateEmail/obfuscateEmail/when URI has the mailto scheme/produces the correct HTML/"

Since this seems to be a non-breaking change, I'm going to temporarily mark this as an expected test failure. If/when you fix the test suite, if you could send a ping so we can change that back that would be great!

@mrkkrp
Copy link
Member

mrkkrp commented Apr 4, 2022

The version 0.2.1.5 (now on Hackage) should not have problems. Thanks for the report!

snoyberg added a commit to commercialhaskell/stackage that referenced this issue Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants