Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes: Gzip Compression, Password Enclosure #21

Merged
merged 5 commits into from
Oct 7, 2014

Conversation

shorrockin
Copy link
Contributor

Howdy, just a few minor changes.

  1. I've enclosed the password in quotations. If your mysql password contained special characters (such as $) the command to connect to the database would not work. By wrapping them this safeguards things. Specs updated.
  2. Minor type-o in error that caught be up, specified s3config, when should of been s3_config
  3. Allowed the compression rate of gzip to be specified in the s3_config file under the key 'compression'. Using a compression rate of -9 was effecting the CPU to the point where it would impact our site. This should allow anyone who wants to, to reduce it.

mmarschall added a commit that referenced this pull request Oct 7, 2014
Minor Fixes: Gzip Compression, Password Enclosure
@mmarschall mmarschall merged commit a72aece into mmarschall:master Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants