Merge pull request redpanda-data#17695 from rockwotj/reset-call-ctx

wasm: reset call context on failure
mmaslankaprv · Apr 7, 2024 · d4dc91b · d4dc91b
2 parents 70298ef + e9877ad
commit d4dc91b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/v/wasm/tests/wasm_transform_test.cc b/src/v/wasm/tests/wasm_transform_test.cc
@@ -59,6 +59,9 @@ TEST_F(WasmTestFixture, HandlesTransformPanic) {
 TEST_F(WasmTestFixture, HandlesTransformErrors) {
     load_wasm("transform-error.wasm");
     EXPECT_THROW(transform(make_tiny_batch()), wasm::wasm_exception);
+    engine()->stop().get();
+    engine()->start().get();
+    EXPECT_THROW(transform(make_tiny_batch()), wasm::wasm_exception);
 }
 
 namespace {

diff --git a/src/v/wasm/transform_module.cc b/src/v/wasm/transform_module.cc
@@ -108,9 +108,8 @@ ss::future<> transform_module::for_each_record_async(
       .callback = cb,
     });
 
-    co_await host_wait_for_proccessing();
-
-    auto result = std::exchange(_call_ctx, std::nullopt);
+    return host_wait_for_proccessing().finally(
+      [this] { _call_ctx = std::nullopt; });
 }
 
 void transform_module::check_abi_version_1() {