Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL version and multisampling fallbacks for pyglet #110

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

mjd3
Copy link
Collaborator

@mjd3 mjd3 commented Apr 27, 2020

Some issues with NoSuchConfigExceptions for Viewer when the maximum OpenGL version on a system was 3.3. This should address that issue by defining target and minimum OpenGL versions and trying different configs (see here for an example). Feel free to edit to remove the None in the list, which allows for a non-templated call to get_best_config().

@mjd3 mjd3 changed the title target/min opengl versions for pyglet config OpenGL version and multisampling fallbacks for pyglet Apr 28, 2020
@mjd3
Copy link
Collaborator Author

mjd3 commented Apr 28, 2020

Added fallbacks for multisampling as well, since it is not supported by some hardware. Basically, the order is now: All options -> -multisampling -> min OpenGL version -> min OpenGL version, -multisampling. See here and here for details.

@mmatl mmatl merged commit 902acf0 into mmatl:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants