Add support for "spherical" joint (from PyBullet) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new joint type isn't covered by the new unit tests, though. I think the humanoid.urdf robot from PyBullet would be make for a suitable one, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #8.
Essentially, "spherical" is an alias for the "floating" joint type, with no translation component in the transformation matrix (I added a check for this in
Joint.get_child_poses()). This is supported by the Bullet/PyBullet physics simulator and represents joints that have free 3D rotation but fixed origin.I took care to add comments in the right places I think.