Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minuteInterval work for iOS DateTimePicker #131

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

antoxann96
Copy link
Contributor

No description provided.

@mmazzarolo
Copy link
Owner

Hey! Thanks for the PR!
To me it's not totally clear tough, isn't passing the minuteInterval prop directly to the DatePickerIOS enough?
Why is it kept in the state? 🤔

@antoxann96
Copy link
Contributor Author

@mmazzarolo Unfortunately not, it is not enough. It works only this way because of some DatePickerIOS specific things. However, i don't think this fix broke anything in future. Just found it and think that probably it will be useful for others same as for me

@mmazzarolo
Copy link
Owner

Oh, ok, that's great! Thanks!

@mmazzarolo mmazzarolo merged commit 9416f26 into mmazzarolo:master Jan 15, 2018
@mmazzarolo
Copy link
Owner

Landed in v5.0.0

@NarendraSingh88
Copy link

Is there any similar prop for this feature in Android?

@MssMaster
Copy link

MssMaster commented Jul 25, 2019

I want to implement this Prop in Android? Is it Possible?

@domlimm
Copy link

domlimm commented May 12, 2020

Android?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants