Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame not generated with the screenshot #1

Closed
fvisticot opened this issue Jan 31, 2019 · 3 comments
Closed

Frame not generated with the screenshot #1

fvisticot opened this issue Jan 31, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@fvisticot
Copy link

fvisticot commented Jan 31, 2019

ImageMagick is available on my MAC.

I have added screenshots to my integration test (test_driver directory)

launch the test:
flutter drive --target=test_driver/my_app.dart

The screenshot is available in the /tmp/screenshots directory

BUT
No frame of the screenshot with iOS device
The directory /tmp/ios is empty (should have framed images here)

config file:

# Screen capture tests
tests:
- test_driver/my_app.dart

# Interim location of screenshots from tests before processing
staging: /tmp/screenshots

# A list of locales supported in app
locales:
- en-US
#  - de-DE

# A list of devices to emulate
devices:
  ios:
  - iPhone X
  - iPhone 7 Plus
  #- iPad Pro (12.9-inch) (2nd generation)
  #   "iPhone 6",
  #   "iPhone 6 Plus",
  #   "iPhone 5",
  #   "iPhone 4s",
  #   "iPad Retina",
  #   "iPad Pro"
  android:
  #- Nexus 5X

# Frame screenshots
frame: true

## final destination of processed screenshots
dest:
  ios: /tmp/ios
  android: /tmp/android
@mmcc007
Copy link
Owner

mmcc007 commented Jan 31, 2019

To launch screenshots use:

screenshots

Per the readme the only destination is:

android/fastlane/metadata/android/en-US/images
ios/fastlane/screenshots/en-US

This is because screenshots is intended to work with fastlane

See currently supported screens in devices.yaml. iPhoneX screen is not among them.

Hope this helps!

@fvisticot
Copy link
Author

Tx, it is working after installing pub
Did you plan

  • to add extra devices for iOS ? would be fine to have iPhoneX screenshots for Appstore.
  • to add text / description

@mmcc007
Copy link
Owner

mmcc007 commented Jan 31, 2019

Great!
I notice some don't have pub installed sometimes (it's included in flutter, BTW).

There's nothing in code to prevent adding more devices (AFAIK). Just need the artwork for clean status bars for each screen. Artwork from frames for all devices (ios and android) is already available.

When I can locate artwork for status bars preferably in sketch (or make my own artwork in sketch I guess), I can add more devices.

Adding text/description is another kettle of fish. It basically requires adding another config file and calls to imageMagick. Not sure how much demand there is for that.

In the meantime, there's nothing to prevent taking a screenshot and adding text and other effects in another custom step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants