-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame not generated with the screenshot #1
Comments
To launch screenshots use:
Per the readme the only destination is:
This is because screenshots is intended to work with fastlane See currently supported screens in devices.yaml. iPhoneX screen is not among them. Hope this helps! |
Tx, it is working after installing pub
|
Great! There's nothing in code to prevent adding more devices (AFAIK). Just need the artwork for clean status bars for each screen. Artwork from frames for all devices (ios and android) is already available. When I can locate artwork for status bars preferably in sketch (or make my own artwork in sketch I guess), I can add more devices. Adding text/description is another kettle of fish. It basically requires adding another config file and calls to imageMagick. Not sure how much demand there is for that. In the meantime, there's nothing to prevent taking a screenshot and adding text and other effects in another custom step. |
Released v0.1.0
ImageMagick is available on my MAC.
I have added screenshots to my integration test (test_driver directory)
launch the test:
flutter drive --target=test_driver/my_app.dart
The screenshot is available in the /tmp/screenshots directory
BUT
No frame of the screenshot with iOS device
The directory /tmp/ios is empty (should have framed images here)
config file:
The text was updated successfully, but these errors were encountered: