Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #1

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Some fixes #1

merged 4 commits into from
Apr 11, 2023

Conversation

vyasr
Copy link
Collaborator

@vyasr vyasr commented Apr 10, 2023

Updating to match the merged version of the libcublas recipe.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

bdice
bdice suggested changes Apr 10, 2023
View reviewed changes
Copy link

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requests.

recipes/libcurand/build.sh Show resolved Hide resolved
recipes/libcurand/meta.yaml Show resolved Hide resolved
recipes/libcurand/meta.yaml Show resolved Hide resolved
recipes/libcurand/meta.yaml Show resolved Hide resolved
@vyasr vyasr merged commit eaf3421 into mmccarty:create-libcurand Apr 11, 2023
@vyasr vyasr deleted the create-libcurand branch April 11, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @bdice