Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/thirdparty: add klauspost/compress s2 encoder #130

Closed
mmcloughlin opened this issue Jan 29, 2020 · 0 comments · Fixed by #131
Closed

tests/thirdparty: add klauspost/compress s2 encoder #130

mmcloughlin opened this issue Jan 29, 2020 · 0 comments · Fixed by #131
Labels
testing Tests and supporting infrastructure

Comments

@mmcloughlin
Copy link
Owner

Now klauspost/compress#186 has landed, we should add it as a third-party test case.

Related #103
@mmcloughlin mmcloughlin added the testing Tests and supporting infrastructure label Jan 29, 2020
mmcloughlin added a commit that referenced this issue Jan 29, 2020
@mmcloughlin
tests/thirdparty: add klauspost/compress/s2
e6ce5ff 
Updates #130
@mmcloughlin mmcloughlin mentioned this issue Jan 29, 2020
Merged
mmcloughlin added a commit that referenced this issue Jan 29, 2020
@mmcloughlin
tests/thirdparty: add klauspost/compress/s2 (#131)
d51141d 
Adds @klauspost's S2 implementation to the third party test suite.

The full klauspost/compress tests are slow but we only care about the S2 sub-package. Therefore this PR also adds the option to only run a subset of the package tests, controlled by a "test" parameter in the JSON configuration.

Closes #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Tests and supporting infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/thirdparty: add klauspost/compress/s2 mmcloughlin/avo
1 participant
@mmcloughlin