Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/thirdparty: add klauspost/compress/s2 #131

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

mmcloughlin
Copy link
Owner

Closes #130

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #131 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   78.04%   78.04%   +<.01%     
==========================================
  Files          55       55              
  Lines       33391    33395       +4     
==========================================
+ Hits        26059    26063       +4     
  Misses       7185     7185              
  Partials      147      147
Flag Coverage Δ
#integration 8.38% <ø> (ø) ⬆️
#unittests 75.62% <100%> (ø) ⬆️
Impacted Files Coverage Δ
tests/thirdparty/config.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e089a6c...787c19d. Read the comment docs.

The full klauspost/compress tests are slow but we only care about one
sub-package.
@mmcloughlin mmcloughlin merged commit d51141d into master Jan 29, 2020
@mmcloughlin mmcloughlin deleted the thirdparty-compress-s2 branch January 29, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/thirdparty: add klauspost/compress s2 encoder
2 participants