use the service's registered context as the cache key #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid making new services per specific-context when the service is registered for a more general interface Fixes #11
mmerickel
force-pushed
the
fix/service-cache-key
branch
from
c35643c
to
bfb898b
Compare
mmerickel
added a commit
that referenced
this pull request
Feb 3, 2016
|
This looks good. I don't see this breaking anything for any of my apps. |
mmerickel
force-pushed
the
fix/service-cache-key
branch
from
b8167c1
to
fa566d7
Compare
mmerickel
added a commit
that referenced
this pull request
Feb 4, 2016
use the service's registered context as the cache key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11