New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents out of screen when using Splash Layout #1169

Closed
imbiansl opened this Issue Aug 9, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@imbiansl

imbiansl commented Aug 9, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Hi! First of all: this theme is awesome!

I've just updated to the newest unreleased version and I found the following problem:

When I use the splash layout with the table of contents and maximize the window, the table appears out of screen and I have to scroll right to find it. It looks like this:

screenshot

(using the Quick-Start Guide as an example)

Though I have little understanding of your project, I believe this is relevant to the last few commits.

Is it possible to fix this problem? Thanks!

@mmistakes mmistakes added the Type: Bug label Aug 9, 2017

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 9, 2017

Owner

Thanks for this. You're right, it was related to the last couple of commits.

Table of contents don't typically show up on the splash layout so it wasn't something I designed for or noticed. Pushing a fix shortly.

Owner

mmistakes commented Aug 9, 2017

Thanks for this. You're right, it was related to the last couple of commits.

Table of contents don't typically show up on the splash layout so it wasn't something I designed for or noticed. Pushing a fix shortly.

@mmistakes mmistakes closed this in d598189 Aug 9, 2017

BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this issue Aug 17, 2017

@vortexing

This comment has been minimized.

Show comment
Hide comment
@vortexing

vortexing Apr 25, 2018

So, in the end, did you decide to prevent toc's on splash pages? I have the same need (the toc to show up either on the side of the text body OR inline). Basically I don't use a sidebar for this particular website, and so it looks really silly unless I use the splash layout.

vortexing commented Apr 25, 2018

So, in the end, did you decide to prevent toc's on splash pages? I have the same need (the toc to show up either on the side of the text body OR inline). Basically I don't use a sidebar for this particular website, and so it looks really silly unless I use the splash layout.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Apr 25, 2018

Owner

@vortexing Right side TOCs should work. I fixed this in the commit d598189 above back in November.

Owner

mmistakes commented Apr 25, 2018

@vortexing Right side TOCs should work. I fixed this in the commit d598189 above back in November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment