Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate disqus_thread in HTML id #1199

Closed
2 of 5 tasks
fantasticfears-stage opened this issue Aug 23, 2017 · 3 comments
Closed
2 of 5 tasks

duplicate disqus_thread in HTML id #1199

fantasticfears-stage opened this issue Aug 23, 2017 · 3 comments

Comments

@fantasticfears-stage
Copy link

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

  • Minimal Mistakes version: 4.5.1
  • github-pages: 155
  • Operating system: OS X 10.12.6

Expected behavior

No duplicate id for disqus_thread in HTML.

Steps to reproduce the behavior

Build with comments.disqus.shortname, the output HTML has the duplicate id in HTML.

@mmistakes
Copy link
Owner

You have a public repo somewhere I can inspect? Hard to tell what's going on without seeing your actual _config.yml and post content.

@mmistakes
Copy link
Owner

Got it. Looks like this was from #1179

<div id="disqus_thread"></div> was added to _includes/comments-providers/disqus.html when it shouldn't have been.

@mmistakes mmistakes self-assigned this Aug 28, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`.

Fixes mmistakes#1199
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`.

Fixes mmistakes#1199
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
`<section id="disqus_thread"></section>` is set in `_includes/comments.html` and not needed in `_includes/comment-provider/disqus.html`.

Fixes mmistakes#1199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants