New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate `disqus_thread` in HTML id #1199

Closed
fantasticfears-stage opened this Issue Aug 23, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@fantasticfears-stage

fantasticfears-stage commented Aug 23, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

  • Minimal Mistakes version: 4.5.1
  • github-pages: 155
  • Operating system: OS X 10.12.6

Expected behavior

No duplicate id for disqus_thread in HTML.

Steps to reproduce the behavior

Build with comments.disqus.shortname, the output HTML has the duplicate id in HTML.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 23, 2017

Owner

You have a public repo somewhere I can inspect? Hard to tell what's going on without seeing your actual _config.yml and post content.

Owner

mmistakes commented Aug 23, 2017

You have a public repo somewhere I can inspect? Hard to tell what's going on without seeing your actual _config.yml and post content.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 23, 2017

Owner

Got it. Looks like this was from #1179

<div id="disqus_thread"></div> was added to _includes/comments-providers/disqus.html when it shouldn't have been.

Owner

mmistakes commented Aug 23, 2017

Got it. Looks like this was from #1179

<div id="disqus_thread"></div> was added to _includes/comments-providers/disqus.html when it shouldn't have been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment