New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed no longer generated #417

Closed
dalemyers opened this Issue Aug 7, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@dalemyers

dalemyers commented Aug 7, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 3.3.6
  • github-pages or jekyll gem version: 89 (github-pages)
  • Operating system: Ubuntu 14.04

Expected behavior

Feed.xml (or whatever is in atom_feed.path) is generated automatically like it used to be.

Steps to reproduce the behavior

Simply build as normal.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 8, 2016

Owner

feed.xml is generated with the Jekyll Feed plugin so make sure that's properly working and installed. The bit in _config.yml is only there to set the feed path that appears in <head> and has nothing to do with generating the actual feed.

If you have a public repo I can give you a better idea of what could be setup wrong.

Owner

mmistakes commented Aug 8, 2016

feed.xml is generated with the Jekyll Feed plugin so make sure that's properly working and installed. The bit in _config.yml is only there to set the feed path that appears in <head> and has nothing to do with generating the actual feed.

If you have a public repo I can give you a better idea of what could be setup wrong.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 8, 2016

Owner

Uncommented the gems lines in _config.yml and the feed should generate again. Gems added to the Jekyll plugin group in a Gemfile are suppose to be autoloaded so you don't need to specify them under gems: in the config. But looks like that's not working with the feed plugin anymore.

gems:
  - jekyll-paginate
  - jekyll-sitemap
  - jekyll-gist
  - jekyll-feed
  - jemoji

Fixed in develop branch b6be3aa

Owner

mmistakes commented Aug 8, 2016

Uncommented the gems lines in _config.yml and the feed should generate again. Gems added to the Jekyll plugin group in a Gemfile are suppose to be autoloaded so you don't need to specify them under gems: in the config. But looks like that's not working with the feed plugin anymore.

gems:
  - jekyll-paginate
  - jekyll-sitemap
  - jekyll-gist
  - jekyll-feed
  - jemoji

Fixed in develop branch b6be3aa

@mmistakes mmistakes self-assigned this Aug 8, 2016

mmistakes added a commit that referenced this issue Aug 8, 2016

@mmistakes mmistakes closed this in 4ac885a Aug 8, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

@Sciss

This comment has been minimized.

Show comment
Hide comment
@Sciss

Sciss Jan 10, 2018

I'm having this problem, I don't know what's going on. I checked bundle install and it lists

Using jekyll-feed 0.9.2

And in _config.yml I do have the defaults:

plugins:
  - jekyll-feed
  ...

But there is no feed.xml generated in _site. Any ideas?

Sciss commented Jan 10, 2018

I'm having this problem, I don't know what's going on. I checked bundle install and it lists

Using jekyll-feed 0.9.2

And in _config.yml I do have the defaults:

plugins:
  - jekyll-feed
  ...

But there is no feed.xml generated in _site. Any ideas?

@Sciss

This comment has been minimized.

Show comment
Hide comment
@Sciss

Sciss Jan 10, 2018

So I browsed a bit, saw this and got the idea that I should use gems instead of plugins. So I added

gems:
  - jekyll-feed

Now it works. What is the difference between plugins and gems?

Sciss commented Jan 10, 2018

So I browsed a bit, saw this and got the idea that I should use gems instead of plugins. So I added

gems:
  - jekyll-feed

Now it works. What is the difference between plugins and gems?

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 10, 2018

Owner

Both should work. There was an update to Jekyll a few releases (I forget which version) ago that changed gems to the more semantic plugins.

plugins is suppose to be backwards compatible but maybe you're using an older version of Jekyll?

Owner

mmistakes commented Jan 10, 2018

Both should work. There was an update to Jekyll a few releases (I forget which version) ago that changed gems to the more semantic plugins.

plugins is suppose to be backwards compatible but maybe you're using an older version of Jekyll?

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 10, 2018

Owner

As per their docs

⚠️ If you are using Jekyll < 3.5.0 use the gems key instead of plugins.

Smells like you're on an older version of Jekyll.

Owner

mmistakes commented Jan 10, 2018

As per their docs

⚠️ If you are using Jekyll < 3.5.0 use the gems key instead of plugins.

Smells like you're on an older version of Jekyll.

@Sciss

This comment has been minimized.

Show comment
Hide comment
@Sciss

Sciss Jan 10, 2018

Hmmm. No it's Jekyll 3.7.0. Strangely it outputs this warning when serving:

Deprecation: The 'gems' configuration option has been renamed to 'plugins'. Please update your config file accordingly.

Nevertheless, if I use plugins and no gems, the feed.xml disappears. Perhaps it's a bug in the plugin.

Sciss commented Jan 10, 2018

Hmmm. No it's Jekyll 3.7.0. Strangely it outputs this warning when serving:

Deprecation: The 'gems' configuration option has been renamed to 'plugins'. Please update your config file accordingly.

Nevertheless, if I use plugins and no gems, the feed.xml disappears. Perhaps it's a bug in the plugin.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 10, 2018

Owner

You're using Bundler correct (eg. bundle exec jekyll serve)? What versions of Jekyll and jekyll-feed are in your Gemfile.lock

That'll tell you really quick what versions of the gems you're using and verify you're on the latest.

Owner

mmistakes commented Jan 10, 2018

You're using Bundler correct (eg. bundle exec jekyll serve)? What versions of Jekyll and jekyll-feed are in your Gemfile.lock

That'll tell you really quick what versions of the gems you're using and verify you're on the latest.

@Sciss

This comment has been minimized.

Show comment
Hide comment
@Sciss

Sciss Jan 10, 2018

Yes, bundle exec jekyll serve. Here is the contents of Gemfile.lock: https://gist.github.com/Sciss/672703625f3067741c4d3ee9ac4feca4

Looks all normal to me? Although I don't understand yet, why the gems have to be specified twice, once in minimal-mistakes-jekyll.gemspec and the second time in _config.yml.

Sciss commented Jan 10, 2018

Yes, bundle exec jekyll serve. Here is the contents of Gemfile.lock: https://gist.github.com/Sciss/672703625f3067741c4d3ee9ac4feca4

Looks all normal to me? Although I don't understand yet, why the gems have to be specified twice, once in minimal-mistakes-jekyll.gemspec and the second time in _config.yml.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 10, 2018

Owner

Yeah looks fine to me.

In my experience plugins are inconsistent with theme gems. I have no idea if it's gotten better with later releases or if it's up to the plugin to autoload. I err on the side of caution and just add them all to the plugins in _config.yml

Owner

mmistakes commented Jan 10, 2018

Yeah looks fine to me.

In my experience plugins are inconsistent with theme gems. I have no idea if it's gotten better with later releases or if it's up to the plugin to autoload. I err on the side of caution and just add them all to the plugins in _config.yml

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment