Added alt to avatar #1226
Merged
Added alt to avatar #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmistakes
reviewed
Sep 5, 2017
_includes/comment.html
Outdated
| @@ -1,6 +1,6 @@ | |||
| <article id="comment{{ include.index }}" class="js-comment comment" itemprop="comment" itemscope itemtype="http://schema.org/Comment"> | |||
| <div class="comment__avatar-wrapper"> | |||
| <img class="comment__avatar" src="https://www.gravatar.com/avatar/{{ include.email }}?d=mm&s=80"> | |||
| <img class="comment__avatar" src="https://www.gravatar.com/avatar/{{ include.email }}?d=mm&s=80" alt="Avatar for {{ include.name }}"> | |||
There was a problem hiding this comment.
Will probably want to use the same method the rest of the theme uses for "localizing" text strings so it can be translated if need be.
Something like alt="{{ site.data.ui-text[site.locale].avatar_for | default: "Avatar for" }} for {{ include.name }}"
And then add avatar_for: "Avatar for" under the English locales in _data/ui-txt.yml
There was a problem hiding this comment.
I removed the Avatar part which seems to be more clever just to have the name instead of having to localize. I could do what you originally suggested also, if you think that it is more clever.
mmistakes
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.