New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Incorporate site search into masthead #1383

Merged
merged 12 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@mmistakes
Owner

mmistakes commented Dec 5, 2017

  • Enable masthead search toggle with site.search == true in _config.yml
  • Toggle search input with button in masthead (magnifying glass icon)
  • Update documentation, add note about _layout/search.html and masthead search not playing nice together. Deprecate search layout?

Example:

masthead-search

Ref #1011

@ohadschn

This comment has been minimized.

Show comment
Hide comment
@ohadschn

ohadschn Dec 5, 2017

Contributor

Wow, nice!!

Contributor

ohadschn commented Dec 5, 2017

Wow, nice!!

mmistakes added some commits Dec 6, 2017

Fix masthead search form padding
Align search form with masthead links.
Improve insertion of search content
Place alongside main content and toggle between them instead of overlaying which produces messy scrollbar heights.
@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Dec 6, 2017

Owner

@ohadschn Thought you'd might enjoy this early holiday 🎁

Owner

mmistakes commented Dec 6, 2017

@ohadschn Thought you'd might enjoy this early holiday 🎁

mmistakes added some commits Dec 6, 2017

Document site search feature
Add .gif showing site search in action and how to enable it via _config.yml variable.
@ohadschn

This comment has been minimized.

Show comment
Hide comment
@ohadschn

ohadschn Dec 6, 2017

Contributor

This is like the Hanukkah Miracle all over again!

Contributor

ohadschn commented Dec 6, 2017

This is like the Hanukkah Miracle all over again!

@justinrummel

This comment has been minimized.

Show comment
Hide comment
@justinrummel

justinrummel Dec 7, 2017

Contributor

Looks Great!

Contributor

justinrummel commented Dec 7, 2017

Looks Great!

@mmistakes mmistakes merged commit 7eb00bb into master Dec 7, 2017

@mmistakes mmistakes deleted the masthead-search branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment